Skip to content

fix(cloudflare): Bind Durable Object built-in handlers#22340

Merged
isaacs merged 2 commits into
developfrom
isaacs/fix-22328
Jul 17, 2026
Merged

fix(cloudflare): Bind Durable Object built-in handlers#22340
isaacs merged 2 commits into
developfrom
isaacs/fix-22328

Conversation

@isaacs

@isaacs isaacs commented Jul 16, 2026 •
edited by JPeer264
Loading

Copy link
Copy Markdown
Member

Bind handlers per instance so a second instance in the same isolate no longer reuses the first instance's captured context and options

fix: #22328
fix: JS-3067

fix: #21153
fix: JS-2607

@isaacs
isaacs requested a review from a team as a code owner July 16, 2026 23:52
@isaacs
isaacs requested review from JPeer264, andreiborza and mydea and removed request for a team July 16, 2026 23:52
@linear-code

linear-code Bot commented Jul 16, 2026 •
edited
Loading

Copy link
Copy Markdown

JS-3067

JS-2607

@isaacs
isaacs force-pushed the isaacs/fix-22328-a branch from 82884e7 to 11eb627 Compare July 16, 2026 23:54
@isaacs
isaacs force-pushed the isaacs/fix-22328 branch from 071d2eb to 56772ae Compare July 16, 2026 23:54
@github-actions

github-actions Bot commented Jul 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

size-limit report 📦

Path Size % Change Change
@sentry/browser 27.74 kB - -
@sentry/browser - with treeshaking flags 26.18 kB - -
@sentry/browser (incl. Tracing) 46.55 kB - -
@sentry/browser (incl. Tracing + Span Streaming) 48.35 kB - -
@sentry/browser (incl. Tracing, Profiling) 51.36 kB - -
@sentry/browser (incl. Tracing, Replay) 85.81 kB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 75.46 kB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 90.52 kB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 103.2 kB - -
@sentry/browser (incl. Feedback) 44.93 kB - -
@sentry/browser (incl. sendFeedback) 32.54 kB - -
@sentry/browser (incl. FeedbackAsync) 37.68 kB - -
@sentry/browser (incl. Metrics) 28.83 kB - -
@sentry/browser (incl. Logs) 29.06 kB - -
@sentry/browser (incl. Metrics & Logs) 29.75 kB - -
@sentry/react 29.54 kB - -
@sentry/react (incl. Tracing) 48.81 kB - -
@sentry/vue 33.17 kB - -
@sentry/vue (incl. Tracing) 48.51 kB - -
@sentry/svelte 27.77 kB - -
CDN Bundle 30.14 kB - -
CDN Bundle (incl. Tracing) 48.52 kB - -
CDN Bundle (incl. Logs, Metrics) 31.73 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) 49.82 kB - -
CDN Bundle (incl. Replay, Logs, Metrics) 70.97 kB - -
CDN Bundle (incl. Tracing, Replay) 86.03 kB - -
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) 87.34 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 91.83 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) 93.09 kB - -
CDN Bundle - uncompressed 89.87 kB - -
CDN Bundle (incl. Tracing) - uncompressed 146.68 kB - -
CDN Bundle (incl. Logs, Metrics) - uncompressed 94.58 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed 150.66 kB - -
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed 219.32 kB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 265.89 kB - -
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed 269.86 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 279.6 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed 283.55 kB - -
@sentry/nextjs (client) 51.36 kB - -
@sentry/sveltekit (client) 46.98 kB - -
@sentry/core/server 78.69 kB - -
@sentry/core/browser 65.06 kB - -
@sentry/node-core 63.21 kB +0.01% +1 B 🔺
@sentry/node 125.52 kB - -
@sentry/node (incl. diagnostics channel injection) 148.06 kB - -
@sentry/node/import (ESM hook with diagnostics-channel injection) 70.03 kB +0.01% +2 B 🔺
@sentry/node/light 51.32 kB +0.01% +1 B 🔺
@sentry/node - without tracing 74.71 kB +0.01% +1 B 🔺
@sentry/aws-serverless 83.92 kB +0.01% +1 B 🔺
@sentry/cloudflare (withSentry) - minified 183.97 kB +0.03% +40 B 🔺
@sentry/cloudflare (withSentry) 455.36 kB +0.02% +50 B 🔺

View base workflow run

JPeer264
JPeer264 approved these changes Jul 17, 2026
View reviewed changes

@JPeer264 JPeer264 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks promising. thx for fixing

Base automatically changed from isaacs/fix-22328-a to develop July 17, 2026 13:55
isaacs added 2 commits July 17, 2026 06:57
@isaacs
fix(cloudflare): Route DO teardown through original waitUntil
6513a65 
Avoid a flush-lock deadlock that prevents WebSocket hibernation.

fix: #22328
fix: JS-3067
@isaacs
fix(cloudflare): Bind Durable Object built-in handlers
6756efb 
Bind handlers per instance so a second instance in the same isolate no
longer reuses the first instance's captured context and options

fix: #22328
fix: JS-3067
@isaacs
isaacs force-pushed the isaacs/fix-22328 branch from 56772ae to 6756efb Compare July 17, 2026 14:01
@isaacs
isaacs merged commit 0b3ad6d into develop Jul 17, 2026
90 checks passed
@isaacs
isaacs deleted the isaacs/fix-22328 branch July 17, 2026 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JPeer264 JPeer264 JPeer264 approved these changes
@andreiborza andreiborza andreiborza approved these changes
@mydea mydea Awaiting requested review from mydea mydea is a code owner automatically assigned from getsentry/team-javascript-sdks-server

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

3 participants

@isaacs @JPeer264 @andreiborza